-
Notifications
You must be signed in to change notification settings - Fork 579
docs: Update instrumentation-runtime-node README.md #2534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
You need to sign the CLA, before we are able to merge this. Follow the steps from the comment above, and you will be able to get it signed. 😄
Sorry, I didn't figure out up front how to CLA signing works from my company pov. (even though this is a small change) |
Np, you can also sign as an individual, not as part of a company. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2534 +/- ##
=======================================
Coverage 90.75% 90.75%
=======================================
Files 169 169
Lines 8018 8018
Branches 1632 1632
=======================================
Hits 7277 7277
Misses 741 741 🚀 New features to boost your workflow:
|
@jeroenjanssen-cpp have you signed the CLA? If so I can run the CI again :) |
Hi @jeroenjanssen-cpp Are you still interested in finalizing this PR, or should we close it? |
Solved by #2786 |
Which problem is this PR solving?
Short description of the changes