-
Notifications
You must be signed in to change notification settings - Fork 579
feat(instrumentation-kafkajs)!: add .tav.yml and narrow support range to (>=0.3.0 <3) #2758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure compatibility by restricting KafkaJS version support to >=0.3.0 <3.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2758 +/- ##
==========================================
+ Coverage 90.51% 90.56% +0.04%
==========================================
Files 166 166
Lines 8020 8020
Branches 1533 1533
==========================================
+ Hits 7259 7263 +4
+ Misses 761 757 -4 🚀 New features to boost your workflow:
|
blumamir
reviewed
Mar 17, 2025
seemk
approved these changes
Mar 18, 2025
pichlermarc
approved these changes
Mar 18, 2025
Merged
deejay1
pushed a commit
to deejay1/opentelemetry-js-contrib
that referenced
this pull request
Apr 14, 2025
… to (>=0.3.0 <3) (open-telemetry#2758) Co-authored-by: Marc Pichler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
KafkaJS versions below 0.3.0 do not properly export Kafka from the main file, causing errors when trying to instrument applications using it.
This PR:
Short description of the changes