Skip to content

feat(exporter-zipkin)!: do not read environment variables from window #5465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

Migrates from getEnv() to using the new get*FromEnv() methods added in #5443. Also inlines the defaults. This drops
"env var configuration" (via window.OTEL_*) in browser environments.

This breaking change now will enable us to split the env var config code completely in a non-breaking feature release later.

Refs #5217

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Existing tests (browser behavior for this was untested, so nothing is added or removed)

@pichlermarc pichlermarc added the target:next-major-release This PR targets the next major release (`next` branch) label Feb 13, 2025
@pichlermarc pichlermarc added this to the OpenTelemetry SDK 2.0 milestone Feb 13, 2025
@pichlermarc pichlermarc requested a review from a team as a code owner February 13, 2025 09:37
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.94%. Comparing base (5c90aec) to head (5097658).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5465   +/-   ##
=======================================
  Coverage   94.94%   94.94%           
=======================================
  Files         309      309           
  Lines        8013     8016    +3     
  Branches     1697     1699    +2     
=======================================
+ Hits         7608     7611    +3     
  Misses        405      405           
Files with missing lines Coverage Δ
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts 100.00% <100.00%> (ø)

@pichlermarc pichlermarc added this pull request to the merge queue Feb 17, 2025
Merged via the queue into open-telemetry:main with commit cc7aa3c Feb 17, 2025
18 checks passed
@pichlermarc pichlermarc deleted the feat/migrate-from-getenv-zipkin branch February 17, 2025 10:22
trentm pushed a commit to trentm/opentelemetry-js that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target:next-major-release This PR targets the next major release (`next` branch)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants