Skip to content

Commit 836c2c7

Browse files
committed
Update httpx implementation
1 parent d0b37c4 commit 836c2c7

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

instrumentation/opentelemetry-instrumentation-httpx/src/opentelemetry/instrumentation/httpx/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ class ResponseInfo(typing.NamedTuple):
209209

210210

211211
def _get_default_span_name(method: str) -> str:
212-
return f"HTTP {method.strip()}"
212+
return method.strip()
213213

214214

215215
def _apply_status_code(span: Span, status_code: int) -> None:

instrumentation/opentelemetry-instrumentation-httpx/tests/test_httpx_integration.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ def test_basic(self):
142142
span = self.assert_span()
143143

144144
self.assertIs(span.kind, trace.SpanKind.CLIENT)
145-
self.assertEqual(span.name, "HTTP GET")
145+
self.assertEqual(span.name, "GET")
146146

147147
self.assertEqual(
148148
span.attributes,
@@ -258,7 +258,7 @@ def test_invalid_url(self):
258258

259259
span = self.assert_span()
260260

261-
self.assertEqual(span.name, "HTTP POST")
261+
self.assertEqual(span.name, "POST")
262262
self.assertEqual(
263263
span.attributes[SpanAttributes.HTTP_METHOD], "POST"
264264
)
@@ -350,7 +350,7 @@ def test_request_hook_no_span_change(self):
350350

351351
self.assertEqual(result.text, "Hello!")
352352
span = self.assert_span()
353-
self.assertEqual(span.name, "HTTP GET")
353+
self.assertEqual(span.name, "GET")
354354

355355
def test_not_recording(self):
356356
with mock.patch("opentelemetry.trace.INVALID_SPAN") as mock_span:
@@ -444,7 +444,7 @@ def test_request_hook_no_span_update(self):
444444

445445
self.assertEqual(result.text, "Hello!")
446446
span = self.assert_span()
447-
self.assertEqual(span.name, "HTTP GET")
447+
self.assertEqual(span.name, "GET")
448448
HTTPXClientInstrumentor().uninstrument()
449449

450450
def test_not_recording(self):

0 commit comments

Comments
 (0)