ASGI instrumentation creates a 'type' attribute

[adriangb]

See

opentelemetry-python-contrib/instrumentation/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py

Line 681 in 7166de6

send_span.set_attribute("type", message["type"])

This results in an attribute like {'type': 'http.request.body'}, which seems wrong. type is a super generic key and I don't think leaking the details of the web framework spec (http.request.body is an ASGI specific string) is very helpful to users.

Can we get rid of this?

[samuelcolvin]

Any answer on this? I still see this apparently undocument type attribute everywhere and would love to understand why it's being included.

[bogdandrutu]

@open-telemetry/opentelemetry-python-contrib-approvers I think we should not use any generic word like "type" in our instrumentations.

[samuelcolvin]

Thanks @bogdandrutu, PR submitted #2145.