Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop sklearn instrumentation #2176

Closed
ocelotl opened this issue Feb 14, 2024 · 2 comments · Fixed by #2708
Closed

Drop sklearn instrumentation #2176

ocelotl opened this issue Feb 14, 2024 · 2 comments · Fixed by #2708
Assignees
@ocelotl

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Feb 14, 2024

We should no longer publish the sklearn package sice it has been deprecated.
@ocelotl ocelotl self-assigned this Feb 14, 2024
ocelotl added a commit to ocelotl/opentelemetry-python-contrib that referenced this issue Jul 15, 2024
@ocelotl
Deprecate sklearn instrumentation
0ebe35a 
Fixes open-telemetry#2176
@ocelotl ocelotl mentioned this issue Jul 15, 2024
Merged
ocelotl added a commit to ocelotl/opentelemetry-python-contrib that referenced this issue Jul 15, 2024
@ocelotl
Deprecate sklearn instrumentation
faa845d 
Fixes open-telemetry#2176
ocelotl added a commit to ocelotl/opentelemetry-python-contrib that referenced this issue Jul 15, 2024
@ocelotl
Deprecate sklearn instrumentation
87b293c 
Fixes open-telemetry#2176
ocelotl added a commit that referenced this issue Jul 16, 2024
@ocelotl
Deprecate sklearn instrumentation (#2708)
5a7935f 
Fixes #2176
@dhpollack
Copy link

The sklearn package is just an alias of scikit-learn which is not deprecated. Would you be open to having a scikit learn telemetry package or was this dropped for another reason? @ocelotl

@lzchen
Copy link
Contributor

lzchen commented Oct 21, 2024

@dhpollack

Would be open to it if there is proper support for the instrumentation. We welcome contributors who are interested in creating one.

xrmx pushed a commit to xrmx/opentelemetry-python-contrib that referenced this issue Jan 24, 2025
@ocelotl @xrmx
Deprecate sklearn instrumentation (open-telemetry#2708)
bfd47a6 
Fixes open-telemetry#2176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocelotl ocelotl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate sklearn instrumentation ocelotl/opentelemetry-python-contrib
3 participants
@dhpollack @ocelotl @lzchen