Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "host.port" attribute to "net.host.port" #240

Closed
malafeev opened this issue Dec 8, 2020 · 0 comments · Fixed by #242
Closed

Rename "host.port" attribute to "net.host.port" #240

malafeev opened this issue Dec 8, 2020 · 0 comments · Fixed by #242
Labels
bug Something isn't working

Comments

@malafeev
Copy link

malafeev commented Dec 8, 2020

According to Semantic Conventions https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/metrics/semantic_conventions/http-metrics.md
attribute "net.host.port" should be used instead of "host.port"
@malafeev malafeev added the bug Something isn't working label Dec 8, 2020
malafeev pushed a commit to malafeev/opentelemetry-python-contrib that referenced this issue Dec 9, 2020
open-telemetry#240 Rename "host.port" attribute to "net.host.port"
61f9076 
Signed-off-by: Sergei Malafeev <[email protected]>
@malafeev malafeev mentioned this issue Dec 9, 2020
Merged
15 tasks
malafeev pushed a commit to malafeev/opentelemetry-python-contrib that referenced this issue Dec 9, 2020
open-telemetry#240 update CHANGELOG.md
97af931 
Signed-off-by: Sergei Malafeev <[email protected]>
malafeev pushed a commit to malafeev/opentelemetry-python-contrib that referenced this issue Dec 9, 2020
open-telemetry#240 fix formatting
1b582c5 
Signed-off-by: Sergei Malafeev <[email protected]>
malafeev pushed a commit to malafeev/opentelemetry-python-contrib that referenced this issue Dec 10, 2020
open-telemetry#240 fix copy-paste issue
15514ab 
Signed-off-by: Sergei Malafeev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename "host.port" attribute to "net.host.port" malafeev/opentelemetry-python-contrib
1 participant
@malafeev