-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aiobotocore instrumentation #1709
Conversation
|
CI is all green in my branch now ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I got assigned due to docs/instrumentation ownership (which looks great). @mariojonke can you take a look? I believe you'll this is your domain 🙏
instrumentation/opentelemetry-instrumentation-aiobotocore/pyproject.toml
Outdated
Show resolved
Hide resolved
...emetry-instrumentation-aiobotocore/src/opentelemetry/instrumentation/aiobotocore/__init__.py
Outdated
Show resolved
Hide resolved
...emetry-instrumentation-aiobotocore/src/opentelemetry/instrumentation/aiobotocore/__init__.py
Show resolved
Hide resolved
...emetry-instrumentation-aiobotocore/src/opentelemetry/instrumentation/aiobotocore/__init__.py
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-aiobotocore/tests/test_aiobotocore_dynamodb.py
Show resolved
Hide resolved
@nemoshlag it's ok if you want to merge the other one first as this will certainly cause a conflict. I can rebase and update |
Hi @dacevedo12 thanks but it's ok. I think new instrumentations should be promoted, but I don't have any control over merging prioritization :) |
Perhaps the bot requested more reviews due to the spellcheck fix in boto3sqs. I just changed it so the CI would pass Any chance this makes it to the 0.38 release 😄 ? |
@dacevedo12 thanks for your precious time and work :) |
They likely won't merge it, check the (ongoing?) discussion at #1714. I'm down to publish this on a separate repo, but won't happen immediately as I'm busy with some stuff. Feel free to fork/copypaste in the meantime, that's what I did at work. |
Will move this to my own repo soon. Progress surely won't be made here. Disappointing. |
Is there any chance to merge this PR? |
Description
Added instrumentor for aiobotocore, an async client for amazon services.
It's based on the sync botocore instrumentor, overriding the methods to patch the async codepaths
Fixes #553
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.