issue 1918: Ensure string values for span status and attribute values #2010
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This aims to fix two cases where data types were deemed invalid, resulting in telemetry not being transmitted to our collector. Specifically:
SpanAttributes.DB_MONGODB_COLLECTION
attribute unless the collection is already a string value.str()
-ify the event failure detailsFixes #1918
Type of change
How Has This Been Tested?
So far, only adhoc testing has been done. Without these changes, we fail to receive telemetry data and see these logged warnings:
With the changes, the warnings are gone and telemetry data flows as expected. We are using pymongo 4.5.0.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.