Add database_index for redis instrumentation #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikanthccv
requested review from
a team,
codeboten and
ocelotl
and removed request for
a team
NathanielRN
approved these changes
Nov 24, 2020
Comment on lines
25
to
29
| db = conn_kwargs.get("db", 0) | ||
| if db == 0: | ||
| attributes["db.name"] = db | ||
| else: | ||
| attributes["db.redis.database_index"] = db |
There was a problem hiding this comment.
I actually think it's okay to just always set it to db.redis.database_index after reading the spec.
Suggested change
| db = conn_kwargs.get("db", 0) | |
| if db == 0: | |
| attributes["db.name"] = db | |
| else: | |
| attributes["db.redis.database_index"] = db | |
| attributes["db.redis.database_index"] = conn_kwargs.get("db", 0) |
If we want to do more we can also do db.name, but I think just this specific attribute is good enough and then let the exporter decide which one to take.
There was a problem hiding this comment.
Spec says it is conditionally required. May be we can set both db.name and db.redis.database_index? Let others also share opinions.
| super().tearDown() | ||
| RedisInstrumentor().uninstrument() | ||
|
|
||
| def _check_span(self, span, name): |
There was a problem hiding this comment.
Probably an unpopular opinion... but since this is only used once I'd be okay with just putting these checks inline in the test_get function until someone else needs same code.
But I'm okay with going with the consensus here.
tests/opentelemetry-docker-tests/tests/redis/test_redis_functional.py
Outdated
Show resolved
Hide resolved
lzchen
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #209