Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not convert grpc.aio.Metadata to OrderedDict #2374

Closed

Conversation

BatmanAoD
Copy link

Description

gRPC metadata has traditionally been represented as nested tuples, so when injecting new metadata, interceptors needed to convert to a mutable type and then back into a nested tuple. However, for async gRPC, the aio.Metadata class breaks this conversion, and the conversion is unnecessary anyway since the data is already mutable.

Fixes #2373

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

TODO

  • Test A

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Copy link

linux-foundation-easycla bot commented Mar 27, 2024

CLA Not Signed

@BatmanAoD
Copy link
Author

I'm not sure why I'm not covered under the CLA. When I click the "not covered" button and go through the process, it says I'm ready to go (as a corporate contributor under Rigetti), but the status of the EasyCLA check doesn't seem to change.

For comparison, in this PR, it marked me as covered: grpc/grpc-go#7038

Is it perhaps because one of my commits here is unverified? (I'm not sure why that is, but I can try to fix it if that's the problem.)

@thpierce
Copy link

I think this issue was resolved with #2363, note that the issue persisted (for me) even after grpc/grpc#26498 was completed.

@BatmanAoD
Copy link
Author

I haven't confirmed whether or not this is resolved, but this PR isn't mergeable anyway.

@BatmanAoD BatmanAoD closed this Aug 21, 2024
@BatmanAoD BatmanAoD deleted the 2373-grpc-metadata-workaround branch August 21, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aio interceptor fails because grpc.aio.Metadata doesn't correctly implement abc.Mapping
2 participants