Skip to content

Removed issue with circular dependency on manual instrumentation. #2749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

mlorenzana
Copy link

Description

Corrected issue on manual instrumentation where an environment variable is expected and if present creates a circular dependency.

Fixes #2056 #2744

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Copy link

linux-foundation-easycla bot commented Jul 29, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@mlorenzana
Copy link
Author

Unless I'm very mistaken, both these issues stem from manual instrumentation from a docker lambda.

In #2744, Docker lambdas do not require the same env vars as zip lambdas since you directly reference the handler method. Thus those variables are always empty when using a docker lambda.

In #2056, the circular dependency comes from assigning the handler to that env var, thus importing the same module twice (and in fact circularly).

In both cases, if the variable is left empty and the instrumentation code exits early, the issues will both be resolved.

@mlorenzana mlorenzana marked this pull request as draft July 29, 2024 15:24
@mlorenzana mlorenzana closed this Jul 30, 2024
@Kludex
Copy link
Contributor

Kludex commented Dec 3, 2024

I'm not using docker, I'm using the Python runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circular Import Issue Caused by AwsLambdaInstrumentor Manual Instrumentation
2 participants