-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertex AI instrumentation boilerplate #3123
Conversation
6ee8502
to
17cbaac
Compare
Nice boilerplate, thanks @aabmass ! I think all other instrumentations can refer to this PR as a template, and build their own instrumentation. I think we probably need a README under https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/instrumentation-genai and add some tips for contribution etc, but we can probably create another PR to address this. |
Nice work! thanks for adding this |
Thanks for review!
We could add to this section https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/CONTRIBUTING.md#guideline-for-genai-instrumentations or break that all out and link is fine with me. |
instrumentation-genai/opentelemetry-instrumentation-vertexai/examples/zero-code/.env
Show resolved
Hide resolved
@@ -0,0 +1,74 @@ | |||
# Copyright The OpenTelemetry Authors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aabmass Happy New Year! May I know why did this instrumentation did not add -v2
? We already have one in openllmetry https://github.com/traceloop/openllmetry/tree/gk/crewai-instrumentation/packages/opentelemetry-instrumentation-vertexai, ,thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current precedent of -v2 was to avoid package names in use by openllmetry
I asked the same on slack, from the angle of how we expect to publish this considering that. I was told that there is a negotiation about re-using the name currently in use by openllmetry (presumably to obviate theirs). I'm not sure if this is only about vertex, or all except openai or something other plan.
Those who can attend the weekly calls may be able to find out more on this topic, and please do share in an issue or issue comment the result of that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, thanks @codefromthecrypt , I think we need a conclusion for this, we already have openai-v2 here, if we agree to use same name as openllmetry, we probably need remove -v2
for openai as well.
* Vertex AI boilerplate copied from openai-v2 * tox.ini boilerplate * tox -e generate,generate-workflows
Description
After the discussion on #3069, I decided to break this up into a series of PRs. This PR contains
s/openai/vertexai
test-requirements-{0,1}.txt
to pip Vertex AI dependencies for testingPart of #3041
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Just boilerplate but I test the examples don't fail and new tests are passing with a placeholder
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.