-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
botocore: add bedrock genai user events and lazy initialize tracer #3258
Conversation
...pentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/__init__.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good I like starting small. despite lazy init being in the same change it makes sense as it shows how it is used as well (for events specifically)
Co-authored-by: Adrian Cole <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Description
This starts implementing genai events support for botocore's bedrock extension. This only implements the user message as a start because they are common to all the APIs and there's already enough code to review.
This includes code to setup different tracers and event loggers (and so schema versions) depending on the extension.
This also removes the pass of AWS authentication environment variables because of security concerns, instead I've added documentation on how to override the tox configuration when needed for recording calls.
Refs #3210
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.