Skip to content

botocore: handle system messages events #3266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 14, 2025

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Feb 13, 2025

Description

This adds handling of system messages and a bunch of tests.

Refs #3210

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e py310-test-opentelemetry-instrumentation-botocore-1

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
xrmx Riccardo Magliocchetti
@xrmx xrmx changed the title botocore: handle system event messages botocore: handle system messages events Feb 13, 2025

Verified

This commit was signed with the committer’s verified signature.
xrmx Riccardo Magliocchetti
@xrmx xrmx requested a review from a team as a code owner February 13, 2025 14:46
@xrmx xrmx added the gen-ai Related to generative AI label Feb 13, 2025

Verified

This commit was signed with the committer’s verified signature.
xrmx Riccardo Magliocchetti
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks also for handling prior versions

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@xrmx xrmx enabled auto-merge (squash) February 14, 2025 10:10
@xrmx xrmx merged commit 789bf86 into open-telemetry:main Feb 14, 2025
694 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gen-ai Related to generative AI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants