Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

botocore: send tool events for bedrock #3302

Merged
merged 4 commits into from
Feb 28, 2025

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Feb 26, 2025

Description

This implements sending tool events for:

  • Converse
  • ConverseStream
  • InvokeModel with anthropic claude 3+ models
  • InvokeMoldeWithStreamResponse with anthropic claude 3+ models

Refs #3210

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e py310-test-instrumentation-botocore

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

This implements sending tool events for:
- Converse
- ConverseStream
- InvokeModel with anthropic claude 3+ models
- InvokeMoldeWithStreamResponse with anthropic claude 3+ models
@xrmx xrmx added the gen-ai Related to generative AI label Feb 26, 2025
@xrmx xrmx requested a review from a team as a code owner February 26, 2025 16:54
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work. As usual, I review last first as that's the tests, then to the main code where I appreciate you added a TODO as well some json examples.

@xrmx xrmx enabled auto-merge (squash) February 28, 2025 08:45
@xrmx xrmx merged commit 2f4d4c5 into open-telemetry:main Feb 28, 2025
705 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gen-ai Related to generative AI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants