Fix threading instrumentation context types #3322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jomcgi
changed the title
jomcgi
force-pushed
the
bug-3321/fix-threading-types
branch
from
a2297f4 to
f3c7738
Compare
jomcgi
changed the title
7 tasks
emdneto
reviewed
Mar 3, 2025
instrumentation/opentelemetry-instrumentation-threading/tests/test_threading.py
Outdated
Show resolved
Hide resolved
Add None check to context handling in threading instrumentation Add testcases for None context
jomcgi
force-pushed
the
bug-3321/fix-threading-types
branch
from
bbd12c9 to
257c8dc
Compare
xrmx
approved these changes
Mar 4, 2025
emdneto
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add None check to context handling in threading instrumentation
Add testcases for None context
Fixes #3321
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
tox -e typechecktox -e test-instrumentation-threadingDoes This PR Require a Core Repo Change?
Checklist: