-
Notifications
You must be signed in to change notification settings - Fork 684
[chore] Address TODO to migrate to VCRpy and remove bespoke RequestMocker code in Google GenAI SDK instrumentation #3344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aabmass
merged 20 commits into
open-telemetry:main
from
michaelsafyan:google_genai_test_improvements
Mar 19, 2025
Merged
[chore] Address TODO to migrate to VCRpy and remove bespoke RequestMocker code in Google GenAI SDK instrumentation #3344
aabmass
merged 20 commits into
open-telemetry:main
from
michaelsafyan:google_genai_test_improvements
Mar 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Friendly ping.... is it possible to get this reviewed? |
nirga
approved these changes
Mar 13, 2025
@michaelsafyan note the failing CI |
Thanks. I had missed those failing checks. Notes for myself for addressing this:
|
lmolkova
approved these changes
Mar 15, 2025
6 tasks
@xrmx sorry for bothering you, but since you commented with a rocket emoji earlier and are one of the maintainers, I'm wondering if I might be able to ask you to get this merged? |
aabmass
approved these changes
Mar 19, 2025
...entation-genai/opentelemetry-instrumentation-google-genai/tests/generate_content/test_e2e.py
Show resolved
Hide resolved
...entation-genai/opentelemetry-instrumentation-google-genai/tests/generate_content/test_e2e.py
Outdated
Show resolved
Hide resolved
...entation-genai/opentelemetry-instrumentation-google-genai/tests/generate_content/test_e2e.py
Show resolved
Hide resolved
Co-authored-by: Aaron Abbott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revises the tests to split up into two different categories:
This addresses prior pull request feedback expressing concern regarding bespoke request mocking and deviation from typical pattern elsewhere of using the VCRpy component. This also addresses the original underlying concerns regarding velocity; since most tests do not use VCRpy and directly mock the underlying GenAI SDK, most feature changes can be tested with much simpler mocks of the GenAI SDK outputs.
Type of change
How Has This Been Tested?
Recorded with:
tox -e py312-test-instrumentation-google-genai-oldest --vcr-record=all
Ran the tests with:
tox -e py312-test-instrumentation-google-genai-oldest
Does This PR Require a Core Repo Change?