Include more request configuration options into the span attributes for the Google GenAI SDK instrumentation #3374
+1,257
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned alizenhom, codefromthecrypt, gyliu513, karthikscale3, lmolkova, lzchen and nirga
github-actions
bot
requested review from
alizenhom,
codefromthecrypt,
gyliu513,
karthikscale3,
lmolkova,
lzchen and
nirga
|
Friendly ping. Is it possible to get this reviewed? |
aabmass
approved these changes
Apr 7, 2025
...try-instrumentation-google-genai/src/opentelemetry/instrumentation/google_genai/dict_util.py
Outdated
Show resolved
Hide resolved
...try-instrumentation-google-genai/src/opentelemetry/instrumentation/google_genai/dict_util.py
Outdated
Show resolved
Hide resolved
...trumentation-google-genai/src/opentelemetry/instrumentation/google_genai/generate_content.py
Show resolved
Hide resolved
...try-instrumentation-google-genai/src/opentelemetry/instrumentation/google_genai/dict_util.py
Show resolved
Hide resolved
...nstrumentation-google-genai/src/opentelemetry/instrumentation/google_genai/allowlist_util.py
Outdated
Show resolved
Hide resolved
2 tasks
lmolkova
reviewed
Apr 16, 2025
...try-instrumentation-google-genai/src/opentelemetry/instrumentation/google_genai/dict_util.py
Show resolved
Hide resolved
|
There is still conversation in SemConv PR 2125 (open-telemetry/semantic-conventions#2125) related to defining the Semantic Conventions for this change. However, I think it would be good to get this in at this time and then circle back if additional changes are required to minimize risk of merge conflicts / bit rotting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves the comprehensiveness and uniformity of reporting span-level attributes for Google GenAI SDK operations.
This essentially dumps all of the configuration options into span attributes, with a vendor-specific prefix. The subset of request options that are defined in OTel Semantic Conventions are then renamed to match conventions.
In service of the above, this change also:
flatten_dictutil used to generate the span attributes.Type of change
How Has This Been Tested?
Added more integration tests, covering the relevant changes.
Does This PR Require a Core Repo Change?
Checklist: