Skip to content

Removed the unnecessary packages from tornado requirements file #3411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025

Conversation

rahulhacker
Copy link
Contributor

@rahulhacker rahulhacker commented Apr 10, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #3173

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e test-instrumentation-tornado

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

@rahulhacker
Copy link
Contributor Author

@shalevr
Can you please skip the changelog, as all the test cases are passing with the current changes?

@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 10, 2025
@xrmx xrmx changed the title Removed the unnesessary packages from tornado requirements file Removed the unnecessary packages from tornado requirements file Apr 10, 2025
@rahulhacker
Copy link
Contributor Author

@xrmx
Thanks for the approval

@rahulhacker rahulhacker force-pushed the issue_3173 branch 2 times, most recently from df3d324 to 198e03d Compare April 10, 2025 17:33
@xrmx
Copy link
Contributor

xrmx commented Apr 14, 2025

@rahulhacker You have to fix the conflicts, better let maintainers edit PRs next time.

@rahulhacker
Copy link
Contributor Author

@xrmx :
Sure, I have resolved the conflicts, and the branch will be pushed from the enterprise shortly.

@rahulhacker
Copy link
Contributor Author

@xrmx :
can you please help in merging the changes??

thanks

@xrmx xrmx merged commit ce90639 into open-telemetry:main Apr 15, 2025
720 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop unneeded requirements from tornado test-requirements
4 participants