-
Notifications
You must be signed in to change notification settings - Fork 684
Add configuration to requests instrumentation readme #556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Normally the docs for this would be available here: https://opentelemetry-python-contrib.readthedocs.io/en/latest/instrumentation/requests/requests.html and look something like https://opentelemetry-python-contrib.readthedocs.io/en/latest/instrumentation/redis/redis.html. This is not working currently because of #552.
@codeboten thanks for the review and the context! Do I have to update changelog to make pipeline happy? |
instrumentation/opentelemetry-instrumentation-requests/README.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Srikanth Chekuri <[email protected]>
Nope, looks like @lonewolf3739 already added the skip changelog label, should be good to go. |
This isn't really consistent with the documentation for the rest of our instrumentations (the |
Ah, I see. the docstrings are not published because of the issue mentioned above. |
Description
Added steps to enable requests instrumentation (currently one has to look to integration tests to see how it has to be done)
Type of change
How Has This Been Tested?
created sample app and saw requests instrumentation tracking span
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.