Fix tox lint command #623
Merged
Fix tox lint command #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
force-pushed
the
fix-lint
branch
4 times, most recently
from
47050f3 to
50c9d52
Compare
owais
requested review from
a team,
codeboten and
ocelotl
and removed request for
a team
|
Looks like this was not the root cause for job getting stuck but it is still an improvement on the current step IMO so we should merge this. |
- Move apt-get install command to github actions to run on an ubuntu system only. This keeps tox.ini cross-platform and enabled to run on non-ubuntu systems locally. - Add `-y` flag to apt-get install command so it does not wait for configuration on CI.
lzchen
approved these changes
Aug 24, 2021
aabmass
approved these changes
Aug 24, 2021
owais
force-pushed
the
fix-lint
branch
2 times, most recently
from
f7f374f to
49d18cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
system only. This keeps tox.ini cross-platform and enabled to run on
non-ubuntu systems locally.
-yflag to apt-get install command so it does not wait forconfiguration on CI.
Type of change
Please delete options that are not relevant.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.