Skip to content

Fix datadog exporter test #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2021
Merged

Fix datadog exporter test #697

merged 2 commits into from
Sep 27, 2021

Conversation

mariojonke
Copy link
Contributor

Fixes the test setup for test_datadog_exporter.test_origin. The test manually creates the spans and used the INVALID_SPAN was used as span ID. So instead of an expected int value, a whole NonRecordingSpan was used.

@mariojonke mariojonke requested a review from a team September 27, 2021 05:51
@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 27, 2021
@codeboten
Copy link
Contributor

/easycla

@lzchen lzchen enabled auto-merge (squash) September 27, 2021 17:22
@lzchen lzchen merged commit 2b0a634 into open-telemetry:main Sep 27, 2021
@mariojonke mariojonke mentioned this pull request Sep 28, 2021
Merged
5 tasks
@mariojonke mariojonke deleted the fix-dd-exporter-test branch October 8, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@lzchen lzchen lzchen approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariojonke @codeboten @lzchen