Skip to content

Use Py Version and Package matrix to distinguish benchmarks #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Use Py Version and Package matrix to distinguish benchmarks #841

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9375da7
Use Py Version and Package matrix to distringuish benchmarks
NathanielRN Dec 23, 2021
af31d4b
Do not fail fast
NathanielRN Dec 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,37 +52,39 @@ jobs:
mkdir -p benchmarks;
jq -s '.[0].benchmarks = ([.[].benchmarks] | add)
| if .[0].benchmarks == null then null else .[0] end'
**/**/tests/*${{ matrix.package }}*-benchmark.json > benchmarks/output_${{ matrix.package }}.json
- name: Upload all benchmarks under same key as an artifact
**/**/tests/*${{ matrix.package }}*-benchmark.json > output_${{ matrix.python-version }}_${{ matrix.package }}.json
- name: Upload benchmarks using (${{ matrix.python-version }}, ${{ matrix.package }}) key
if: ${{ success() }}
uses: actions/upload-artifact@v2
with:
name: benchmarks
path: benchmarks/output_${{ matrix.package }}.json
name: benchmarks_${{ matrix.python-version }}_${{ matrix.package }}
path: output_${{ matrix.python-version }}_${{ matrix.package }}.json
combine-benchmarks:
runs-on: ubuntu-latest
needs: build
if: ${{ always() }}
name: Combine benchmarks from previous build job
strategy:
fail-fast: false
max-parallel: 1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We run serially because the github-action-benchmark GH action takes a lock on the gh-pages branch.

matrix:
python-version: [ py36, py37, py38, py39, py310, pypy3 ]
# TODO: Add "instrumentation", "distro", "exporter", when they have benchmarks
package: ["sdkextension", "propagator"]
steps:
- name: Checkout Contrib Repo @ SHA - ${{ github.sha }}
uses: actions/checkout@v2
- name: Download all benchmarks as artifact using key
- name: Download benchmarks using (${{ matrix.python-version }}, ${{ matrix.package }}) key
uses: actions/download-artifact@v2
with:
name: benchmarks
path: benchmarks
- name: Find and merge all benchmarks
run: >-
jq -s '.[0].benchmarks = ([.[].benchmarks] | add)
| if .[0].benchmarks == null then null else .[0] end'
benchmarks/output_*.json > output.json;
name: benchmarks_${{ matrix.python-version }}_${{ matrix.package }}
path: output_${{ matrix.python-version }}_${{ matrix.package }}.json
- name: Report on benchmark results
uses: benchmark-action/github-action-benchmark@v1
with:
name: OpenTelemetry Python Benchmarks - Python ${{ env[matrix.python-version ]}} - ${{ matrix.package }}
tool: pytest
output-file-path: output.json
output-file-path: output_${{ matrix.python-version }}_${{ matrix.package }}.json
github-token: ${{ secrets.GITHUB_TOKEN }}
max-items-in-chart: 100
# Alert with a commit comment on possible performance regression
Expand Down