Skip to content

[instrumentation/pyramid] Conditionally create SERVER spans #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sanketmehta28
Copy link
Member

@sanketmehta28 sanketmehta28 commented Jan 17, 2022

Description

This code change resolves the conditional span creation for pyramid framework in case of other framework is used as well. This fix will use the existing span and make the new span its child and create a parent child relation which is the right behavior

Fixes #449

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I have added the unit test cases in test_automatic.py for this code change where I have added a span in current context and send a request using test client which will create the child span and I have checked that parent.id of the newly created span is equal to the id of the existing span.

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Unit tests have been added

@sanketmehta28 sanketmehta28 requested a review from a team January 17, 2022 16:14
@linux-foundation-easycla
Copy link

CLA Not Signed

@codeboten codeboten changed the title code change to resolve the bug https://github.com/open-telemetry/open… [instrumentation/pyramid] Conditionally create SERVER spans Jan 17, 2022
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @sanketmehta28! Please make sure to sign the CLA to get this change reviewed and merged.

@linux-foundation-easycla
Copy link

CLA Not Signed

@sanketmehta28 sanketmehta28 deleted the condition_server_span_pyramid branch January 19, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pyramid: Conditionally create SERVER spans
2 participants