[instrumentation/pyramid] Conditionally create SERVER spans #865
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This code change resolves the conditional span creation for pyramid framework in case of other framework is used as well. This fix will use the existing span and make the new span its child and create a parent child relation which is the right behavior
Fixes #449
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I have added the unit test cases in test_automatic.py for this code change where I have added a span in current context and send a request using test client which will create the child span and I have checked that parent.id of the newly created span is equal to the id of the existing span.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.