Skip to content

Make environment variables accessible from a central place #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ocelotl opened this issue Jul 19, 2021 · 3 comments · Fixed by #1969
Closed

Make environment variables accessible from a central place #1968

ocelotl opened this issue Jul 19, 2021 · 3 comments · Fixed by #1969
Assignees
@ocelotl
Labels
enhancement New feature or request

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Jul 19, 2021

Environment variables need to be defined in separate places but accessible from a single one. This way a distro or configurator can have access to all the environment variables that have been defined in all the opentelemetry-components.
@ocelotl ocelotl added the enhancement New feature or request label Jul 19, 2021
@ocelotl ocelotl self-assigned this Jul 19, 2021
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jul 19, 2021
@ocelotl
Make opentelemetry.environment_variables a single namespace
3d0345e 
Fixes open-telemetry#1968
@ocelotl ocelotl mentioned this issue Jul 19, 2021
Merged
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jul 19, 2021
@ocelotl
Make opentelemetry.environment_variables a single namespace
c0e7523 
Fixes open-telemetry#1968
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jul 19, 2021
@ocelotl
Make opentelemetry.environment_variables a single namespace
f5f888f 
Fixes open-telemetry#1968
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jul 19, 2021
@ocelotl
Make opentelemetry.environment_variables a single namespace
4c1463f 
Fixes open-telemetry#1968
@github-actions
Copy link

This issue was marked stale due to lack of activity. It will be closed in 30 days.

@lzchen
Copy link
Contributor

lzchen commented Aug 19, 2021

I believe this can be closed due to this and this.

@lzchen lzchen closed this as completed Aug 19, 2021
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Aug 23, 2021
@ocelotl
Make opentelemetry.environment_variables a single namespace
b5661f4 
Fixes open-telemetry#1968
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Aug 25, 2021
@ocelotl
Make opentelemetry.environment_variables a single namespace
a32481f 
Fixes open-telemetry#1968
@ocelotl
Copy link
Contributor Author

ocelotl commented Aug 25, 2021

Reopening, opentelemetry-instrument can use this to load all environment variables as options.

@ocelotl ocelotl reopened this Aug 25, 2021
@github-actions github-actions bot removed the backlog label Aug 26, 2021
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Aug 26, 2021
@ocelotl
Make opentelemetry.environment_variables a single namespace
4a534c6 
Fixes open-telemetry#1968
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 9, 2021
@ocelotl
Make opentelemetry.environment_variables a single namespace
2133f19 
Fixes open-telemetry#1968
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Sep 28, 2021
@ocelotl
Make opentelemetry.environment_variables a single namespace
f32bdae 
Fixes open-telemetry#1968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocelotl ocelotl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Load environment variables as options for opentelemetry-instrument ocelotl/opentelemetry-python
2 participants
@ocelotl @lzchen