Skip to content

Make necessary SDK metrics symbols private #2389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ocelotl opened this issue Jan 18, 2022 · 2 comments · Fixed by #2625
Closed

Make necessary SDK metrics symbols private #2389

ocelotl opened this issue Jan 18, 2022 · 2 comments · Fixed by #2625
Assignees
@ocelotl
Labels
1.10.0rc1 release candidate 1 for metrics GA api Affects the API package. metrics sdk Affects the SDK package.

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Jan 18, 2022

Most of the stuff in the opentelemetry/sdk/_metrics package should be private. Can we fix it for everything in a follow up PR?

Originally posted by @aabmass in #2388 (comment)
@ocelotl ocelotl mentioned this issue Jan 18, 2022
Merged
4 tasks
@aabmass aabmass self-assigned this Jan 19, 2022
@aabmass aabmass added api Affects the API package. sdk Affects the SDK package. labels Jan 19, 2022
@aabmass
Copy link
Member

aabmass commented Jan 19, 2022

This should probably be fixed for both the SDK and API in two separate PRs.

@aabmass aabmass mentioned this issue Feb 17, 2022
Merged
4 tasks
@aabmass aabmass mentioned this issue Feb 24, 2022
Merged
@ocelotl ocelotl added the 1.10.0rc1 release candidate 1 for metrics GA label Apr 12, 2022
@ocelotl ocelotl assigned ocelotl and unassigned aabmass Apr 19, 2022
@ocelotl ocelotl changed the title Make necessary metrics symbols private Make necessary SDK metrics symbols private Apr 20, 2022
@ocelotl ocelotl mentioned this issue Apr 20, 2022
Closed
@ocelotl
Copy link
Contributor Author

ocelotl commented Apr 20, 2022

This should probably be fixed for both the SDK and API in two separate PRs.

Opened #2622

ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Apr 20, 2022
@ocelotl
Make necessary SDK metrics symbols private
97306b6 
Fixes open-telemetry#2389
@ocelotl ocelotl mentioned this issue Apr 20, 2022
Merged
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Apr 20, 2022
@ocelotl
Make necessary SDK metrics symbols private
5772f30 
Fixes open-telemetry#2389
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Apr 20, 2022
@ocelotl
Make necessary SDK metrics symbols private
6a57aa3 
Fixes open-telemetry#2389
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Apr 20, 2022
@ocelotl
Make necessary SDK metrics symbols private
3b0c499 
Fixes open-telemetry#2389
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Apr 29, 2022
@ocelotl
Make necessary SDK metrics symbols private
2f80663 
Fixes open-telemetry#2389
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Apr 29, 2022
@ocelotl
Make necessary SDK metrics symbols private
b681b24 
Fixes open-telemetry#2389
ocelotl added a commit that referenced this issue May 2, 2022
@ocelotl
Make necessary SDK metrics symbols private (#2625)
cdab6e1 
Fixes #2389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocelotl ocelotl

Labels
1.10.0rc1 release candidate 1 for metrics GA api Affects the API package. metrics sdk Affects the SDK package.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make necessary SDK metrics symbols private ocelotl/opentelemetry-python
2 participants
@aabmass @ocelotl