Skip to content

Check instrument names and units #2647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ocelotl opened this issue Apr 28, 2022 · 0 comments · Fixed by #2648
Closed

Check instrument names and units #2647

ocelotl opened this issue Apr 28, 2022 · 0 comments · Fixed by #2648
Assignees
@ocelotl
Labels
1.10.0rc1 release candidate 1 for metrics GA metrics

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Apr 28, 2022

The API spec says instrument names and units should conform to certain standards. Check that they do.
@ocelotl ocelotl added metrics 1.10.0rc1 release candidate 1 for metrics GA labels Apr 28, 2022
@ocelotl ocelotl self-assigned this Apr 28, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Apr 28, 2022
@ocelotl
Check instrument names and units
508f06e 
Fixes open-telemetry#2647
@ocelotl ocelotl mentioned this issue Apr 28, 2022
Merged
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Apr 29, 2022
@ocelotl
Check instrument names and units
0bd6160 
Fixes open-telemetry#2647
ocelotl added a commit that referenced this issue Apr 29, 2022
@ocelotl @srikanthccv
Check instrument names and units (#2648)
5456988 
* Check instrument names and units

Fixes #2647

* Update opentelemetry-api/src/opentelemetry/_metrics/instrument.py

Co-authored-by: Srikanth Chekuri <[email protected]>

* Add missing type

* Add missing type

* Fix error message

* Update opentelemetry-api/src/opentelemetry/_metrics/_internal/instrument.py

Co-authored-by: Srikanth Chekuri <[email protected]>

Co-authored-by: Srikanth Chekuri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocelotl ocelotl

Labels
1.10.0rc1 release candidate 1 for metrics GA metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check instrument names and units ocelotl/opentelemetry-python
1 participant
@ocelotl