Skip to content

Update main after 1.0.0rc1 release #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 16, 2021
Merged

Update main after 1.0.0rc1 release #1603

merged 3 commits into from
Feb 16, 2021

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Feb 12, 2021

No description provided.

@lzchen lzchen requested review from a team, codeboten and hectorhdzg and removed request for a team February 12, 2021 23:31
codeboten
codeboten approved these changes Feb 13, 2021
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit in the changelog, otherwise this looks good

codeboten
codeboten reviewed Feb 16, 2021
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the line about urllib have been moved to unreleased?

CHANGELOG.md
@@ -23,14 +29,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
([#1480](https://github.com/open-telemetry/opentelemetry-python/pull/1480))
- Allow missing carrier headers to continue without raising AttributeError
([#1545](https://github.com/open-telemetry/opentelemetry-python/pull/1545))
- Add urllib to opentelemetry-bootstrap target list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did this line go?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be added to the 0.18b release since the change does not pertain to any rc1 package.

@lzchen lzchen merged commit a3d23a8 into open-telemetry:main Feb 16, 2021
@lzchen lzchen deleted the version branch February 16, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@owais owais owais approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

@hectorhdzg hectorhdzg Awaiting requested review from hectorhdzg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lzchen @owais @codeboten @srikanthccv