Move the metrics basic test to TestBase class #3092
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalevr
force-pushed
the
Move-metrics-basic-test-to-TestBase
branch
4 times, most recently
from
934c9b5 to
8c56a37
Compare
shalevr
force-pushed
the
Move-metrics-basic-test-to-TestBase
branch
from
8c56a37 to
459bb92
Compare
osherv
reviewed
Dec 15, 2022
osherv
approved these changes
Dec 15, 2022
srikanthccv
reviewed
Dec 18, 2022
tests/opentelemetry-test-utils/src/opentelemetry/test/test_base.py
Outdated
Show resolved
Hide resolved
| self.assertEqual( | ||
| data_point.sum, | ||
| expected_value, | ||
| ) |
There was a problem hiding this comment.
Where are min, max, count etc... assertions?
tests/opentelemetry-test-utils/src/opentelemetry/test/test_base.py
Outdated
Show resolved
Hide resolved
|
Can you add a Skip Changelog label? |
srikanthccv
reviewed
Dec 19, 2022
tests/opentelemetry-test-utils/src/opentelemetry/test/test_base.py
Outdated
Show resolved
Hide resolved
tests/opentelemetry-test-utils/src/opentelemetry/test/test_base.py
Outdated
Show resolved
Hide resolved
tests/opentelemetry-test-utils/src/opentelemetry/test/test_base.py
Outdated
Show resolved
Hide resolved
shalevr
force-pushed
the
Move-metrics-basic-test-to-TestBase
branch
from
bcc7b78 to
eb27734
Compare
11 tasks
srikanthccv
reviewed
Jan 21, 2023
Comment on lines
+117
to
+118
| metric: Metric, | ||
| expected_value: Union[int, float], |
There was a problem hiding this comment.
The way I would find this useful is if it takes the current metric and the expected metric, not a single float/int value. The following code has things that don't make it useable for many use cases; why does the count have to be 1? How can one use this when the count is not 1? There are no assertions of min, max etc.?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move the metrics basic test to TestBase class so each metric instrumentation could use those functions
The functions moved from the tornado instrumentation test:
https://github.com/open-telemetry/opentelemetry-python-contrib/blob/0f2451be26c87a366d44283022341fc904c88b22/instrumentation/opentelemetry-instrumentation-tornado/tests/test_metrics_instrumentation.py#L38
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR:
No.
Checklist: