-
Notifications
You must be signed in to change notification settings - Fork 698
Type json indent as optional #4402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@NN--- the change looks good but can you add some context? Also why would you want to pass |
I want to write json to file with each span on a single line. |
It turns out that Optional is deprecated in favor of type | None. |
Were you planning on making this change? |
I think making this in a separate PR. |
This syntax wont work for py38 and will break a lot of tests in contrib, so better to leave for another PR |
Description
Python
json.dumps
has optional indent parameter which is not reflected in the API.This is not a breaking change, only the type is updated.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
No test is needed, it is only typing change.
Does This PR Require a Contrib Repo Change?
7
Checklist: