-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken link in Prometheus exporter README. Fixes #4399 #4485
base: main
Are you sure you want to change the base?
Fix broken link in Prometheus exporter README. Fixes #4399 #4485
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are still missing the prometheus-exporter docs published on the opentelemetry-python readthedocs
8f1efc4
to
e392725
Compare
df0832f
to
3e12137
Compare
Could you please take a look now @emdneto |
…tation. Fixes open-telemetry#4399 Signed-off-by: Yogi Suthari <[email protected]>
3e12137
to
ba0885b
Compare
Co-authored-by: Emídio Neto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when docs CI gets fixed. I think it's just a matter of adding the prometheus_client dependency in tox
Description
This PR fixes the broken link in the Prometheus exporter README.rst by updating it to point to the current documentation location on opentelemetry.io.
The old link pointed to a non-existent page on readthedocs:
https://opentelemetry-python.readthedocs.io/en/latest/exporter/prometheus/prometheus.html
The new link points to the current documentation:
https://opentelemetry.io/docs/instrumentation/python/exporters/#prometheus
Fixes #4399
Type of change
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: