opentelemetry-api: review get_logger documentation #4507
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
commented
Mar 26, 2025
| @@ -162,29 +162,29 @@ def get_logger( | |||
| ) -> Logger: | |||
| """Returns a `Logger` for use by the given instrumentation library. | |||
|
|
|||
| For any two calls it is undefined whether the same or different | |||
| `Logger` instances are returned, even for different library names. | |||
| Calls with the same arguments should return the same `Logger` instance. | |||
There was a problem hiding this comment.
I think this does not match what the sdk is doing though
There was a problem hiding this comment.
Do you mean there's something wrong with the logic previously implemented by #4208 ?
There was a problem hiding this comment.
I mean this #4318 (comment)
pmcollins
approved these changes
Mar 26, 2025
emdneto
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4318
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: