opentelemetry-sdk: use release candidate code attributes #4508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using the deprecated use latest release candidate code attributes. While at it stop using SpanAttributes.
xrmx
commented
Mar 26, 2025
| @@ -17,6 +17,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ([#4494](https://github.com/open-telemetry/opentelemetry-python/pull/4494)) | |||
| - Improve CI by cancelling stale runs and setting timeouts | |||
| ([#4498](https://github.com/open-telemetry/opentelemetry-python/pull/4498)) | |||
| - opentelemetry-sdk: use release candidate code attributes | |||
There was a problem hiding this comment.
Suggested change
| - opentelemetry-sdk: use release candidate code attributes | |
| - opentelemetry-sdk: use release candidate code attributes: `code.function` -> `code.function.name`, `code.lineno` -> `code.line.number`, `code.filepath` -> `code.file.path` |
jomcgi
approved these changes
Mar 31, 2025
emdneto
approved these changes
Apr 1, 2025
There was a problem hiding this comment.
Since code semconv is in Release Candidate status, I'm good with the change.
https://opentelemetry.io/docs/specs/semconv/code/
Existing code instrumentations that are using v1.29.0 of code conventions (or prior):
SHOULD NOT change the version of the code conventions that they emit by default until the code semantic conventions are marked stable.
| if value is not None and value.args: | ||
| attributes[SpanAttributes.EXCEPTION_MESSAGE] = str( | ||
| attributes[exception_attributes.EXCEPTION_MESSAGE] = str( | ||
| value.args[0] | ||
| ) | ||
| if tb is not None: | ||
| # https://github.com/open-telemetry/opentelemetry-specification/blob/9fa7c656b26647b27e485a6af7e38dc716eba98a/specification/trace/semantic_conventions/exceptions.md#stacktrace-representation |
There was a problem hiding this comment.
While we are still here, can you change the URL to point to the main one?
pmcollins
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of using the deprecated use latest release candidate code attributes.
While at it stop using SpanAttributes.
This is similar to what the go sdk is doing open-telemetry/opentelemetry-go-contrib#6870
Refs #4316
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: