opentelemetry-sdk: fix serialization of objects in log handler #4528
+56
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should convert to string objects that are not AnyValues because otherwise exporter will fail later in the pipeline. While the export of all AnyValue types is not correct yet, exporter tests expects to being able to handle them and so they are already used in the handler.
xrmx
force-pushed
the
fix-serialization-of-objects-in-logs
branch
from
9e69c15 to
2f9417a
Compare
emdneto
reviewed
Apr 7, 2025
emdneto
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We should convert to string objects that are not AnyValues because otherwise exporter will fail later in the pipeline. While the export of all AnyValue types is not correct yet, exporter tests expects to being able to handle them and so they are already used in the handler.
Fixes #4509
Fixes #4409
Closes #4510
Closes #4514
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: