-
Notifications
You must be signed in to change notification settings - Fork 698
Add cloud monitoring exporter #739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cloud monitoring exporter #739
Conversation
7f266dc
to
aa6d73a
Compare
...ntelemetry-exporter-cloud-monitoring/src/opentelemetry/exporter/cloud_monitoring/__init__.py
Show resolved
Hide resolved
...ntelemetry-exporter-cloud-monitoring/src/opentelemetry/exporter/cloud_monitoring/__init__.py
Show resolved
Hide resolved
...ntelemetry-exporter-cloud-monitoring/src/opentelemetry/exporter/cloud_monitoring/__init__.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
...ntelemetry-exporter-cloud-monitoring/src/opentelemetry/exporter/cloud_monitoring/__init__.py
Show resolved
Hide resolved
...ntelemetry-exporter-cloud-monitoring/src/opentelemetry/exporter/cloud_monitoring/__init__.py
Outdated
Show resolved
Hide resolved
...ntelemetry-exporter-cloud-monitoring/src/opentelemetry/exporter/cloud_monitoring/__init__.py
Show resolved
Hide resolved
...ntelemetry-exporter-cloud-monitoring/src/opentelemetry/exporter/cloud_monitoring/__init__.py
Outdated
Show resolved
Hide resolved
ext/opentelemetry-exporter-cloud-monitoring/tests/test_cloud_monitoring.py
Outdated
Show resolved
Hide resolved
...ntelemetry-exporter-cloud-monitoring/src/opentelemetry/exporter/cloud_monitoring/__init__.py
Outdated
Show resolved
Hide resolved
8255fbf
to
836faf5
Compare
bbae5e6
to
d1fa22a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No blocking comments, just nits. Looks like a great start!
google-cloud-monitoring | ||
|
||
[options.packages.find] | ||
where = src |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where = src | |
where = src |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your commit suggestion has no change, can you clarify?
...ntelemetry-exporter-cloud-monitoring/src/opentelemetry/exporter/cloud_monitoring/__init__.py
Outdated
Show resolved
Hide resolved
...ntelemetry-exporter-cloud-monitoring/src/opentelemetry/exporter/cloud_monitoring/__init__.py
Show resolved
Hide resolved
...ntelemetry-exporter-cloud-monitoring/src/opentelemetry/exporter/cloud_monitoring/__init__.py
Show resolved
Hide resolved
...ntelemetry-exporter-cloud-monitoring/src/opentelemetry/exporter/cloud_monitoring/__init__.py
Outdated
Show resolved
Hide resolved
ext/opentelemetry-exporter-cloud-monitoring/tests/test_cloud_monitoring.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Kleinknecht <[email protected]>
Co-authored-by: Chris Kleinknecht <[email protected]>
Co-authored-by: Chris Kleinknecht <[email protected]>
Co-authored-by: Chris Kleinknecht <[email protected]>
…exporter/cloud_monitoring/__init__.py Co-authored-by: Chris Kleinknecht <[email protected]>
…exporter/cloud_monitoring/__init__.py Co-authored-by: Chris Kleinknecht <[email protected]>
…onitoring.py Co-authored-by: Chris Kleinknecht <[email protected]>
88b6cb5
to
86c5157
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm giving it more of an abstract code review, vs checking implementation correctness. I think you have enough cloud monitoring experts here for that :)
Adding an exporter that supports sending metrics data to cloud monitoring (formerly known as stackdriver). Co-authored-by: Chris Kleinknecht <[email protected]> Co-authored-by: Yusuke Tsutsumi <[email protected]>
Adding an exporter that supports sending metrics data to cloud monitoring (formerly known as stackdriver). Addresses issue #736