Skip to content

Docs for Pyramid and SQLite3 #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 13, 2020
Merged

Docs for Pyramid and SQLite3 #806

merged 4 commits into from
Jun 13, 2020

Conversation

cnnradams
Copy link
Member

@cnnradams cnnradams commented Jun 10, 2020 •
edited by codeboten
Loading

I missed this in my last 2 instrumentation PRs 😬

Also did some formatting for the Pyramid docs

Fixes #805

@cnnradams cnnradams requested a review from a team June 10, 2020 22:00
codeboten
codeboten approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, just a non-blocking question

toumorokoshi
toumorokoshi approved these changes Jun 13, 2020
View reviewed changes
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@toumorokoshi toumorokoshi merged commit 74f2159 into open-telemetry:master Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@toumorokoshi toumorokoshi toumorokoshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ext/pyramid: add docs page
3 participants
@cnnradams @codeboten @toumorokoshi