Skip to content

chore: moving code to prepare the release to eachdist #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 16, 2020

Conversation

codeboten
Copy link
Contributor

Moving some of the prepare_release.sh script into eachdist.py to clean up the process to prepare a release.

@codeboten codeboten requested a review from a team June 10, 2020 23:39
@lzchen
Copy link
Contributor

lzchen commented Jun 10, 2020

Does RELEASING.md need to be updated as well?

@codeboten
Copy link
Contributor Author

Does RELEASING.md need to be updated as well?

No, prepare_release.sh still deals with git commands and version parsing

Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, when it comes to generate files from arguments it is better to use Jinja templates.

@toumorokoshi toumorokoshi merged commit 17558b8 into open-telemetry:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants