-
Notifications
You must be signed in to change notification settings - Fork 698
chore: moving code to prepare the release to eachdist #808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: moving code to prepare the release to eachdist #808
Conversation
Does |
No, prepare_release.sh still deals with git commands and version parsing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, when it comes to generate files from arguments it is better to use Jinja templates.
Moving some of the prepare_release.sh script into eachdist.py to clean up the process to prepare a release.