feat(wsgi): low cardinality span name and name override #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emil Madsen <[email protected]>
…rdinality_span_names
ocelotl
suggested changes
Jun 18, 2020
There was a problem hiding this comment.
A couple minor changes requested. Only one comment requires attention, there may be a bug on the implementation of get_default_span_name, so please just respond to it, @majorgreys.
ext/opentelemetry-ext-wsgi/src/opentelemetry/ext/wsgi/__init__.py
Outdated
Show resolved
Hide resolved
ext/opentelemetry-ext-wsgi/src/opentelemetry/ext/wsgi/__init__.py
Outdated
Show resolved
Hide resolved
Comment on lines
+154
to
+156
| def get_predefined_span_name(scope): | ||
| # pylint: disable=unused-argument | ||
| return span_name |
There was a problem hiding this comment.
Nit: this could be replaced with a Mock:
In [4]: from unittest.mock import Mock
In [5]: the_mock = Mock(**{"return_value": "Dymaxion"})
In [6]: the_mock({"a": "b"})
Out[6]: 'Dymaxion'
ocelotl
approved these changes
Jun 22, 2020
ext/opentelemetry-ext-wsgi/src/opentelemetry/ext/wsgi/__init__.py
Outdated
Show resolved
Hide resolved
ext/opentelemetry-ext-wsgi/src/opentelemetry/ext/wsgi/__init__.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Diego Hurtado <[email protected]>
cnnradams
pushed a commit
to cnnradams/opentelemetry-python
that referenced
this pull request
Jul 2, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #440