Add GitHub Action for tox runs #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ffe4
changed the title
ffe4
force-pushed
the
gha-tox
branch
2 times, most recently
from
4585c47 to
be07a72
Compare
The Python 3.5 intrumentation test segfaults when importing the mysql connector. Running this test on Ubuntu-20.04 fixes this issue.
ffe4
changed the title
codeboten
approved these changes
Sep 9, 2020
If it is merged first I will push an update. |
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A GHA test workflow as suggested in #870. The workflow runs the same jobs as the CircleCI workflow and all jobs cache the
.toxdirectory. Thepy35-instrumentationtest segfails on ubuntu-18.04. As a workaround it is running it on 20.04 instead.GHA has 5GB of cache space, after which old caches get deleted. This should be enough to cache two iterations of
tox.ini/dev-requirements.txt. The OTEL org has a shared concurrency limit of at least 60 jobs according to this comment.Here’s a table with completion times of the most recent cached runs.
Fixes #870