Skip to content

Remove cardinality capping in Metrics #2528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cijothomas
Copy link
Member

#1951 (comment)

To support customizing cardinality cap, we need to use Views, but Views are behind experimental feature flag. Though it is possible to offer a MetricReader level way to configure the limit, it is better to offer the per-metric capability via Views too. Until ability to customize the feature is available, it is better to remove the cardinality capping from the SDK.

(Note that the CardinalityCapping spec is relatively new to OTel and just stabilized few months ago, so this is not a mandatory feature to have for the stable release)

@cijothomas cijothomas requested a review from a team as a code owner January 22, 2025 01:25
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.8%. Comparing base (d2a6b3b) to head (cc261af).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2528     +/-   ##
=======================================
- Coverage   78.0%   77.8%   -0.3%     
=======================================
  Files        123     123             
  Lines      23056   23059      +3     
=======================================
- Hits       17984   17940     -44     
- Misses      5072    5119     +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 90b0dd4 into open-telemetry:main Jan 22, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants