-
Notifications
You must be signed in to change notification settings - Fork 525
Split SimpleLogProcessor and BatchLogProcessor out of single file #2661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split SimpleLogProcessor and BatchLogProcessor out of single file #2661
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2661 +/- ##
=====================================
Coverage 79.1% 79.1%
=====================================
Files 120 122 +2
Lines 22562 22562
=====================================
Hits 17861 17861
Misses 4701 4701 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Lalit Kumar Bhasin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! There are other places that could benefit from similar rearrangement, feel free to explore and make changes when you have bandwidth!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks.
….com/drewrelmas/opentelemetry-rust into drewrelmas/split-log-processor-impls
Fixes # N/A
Design discussion issue (if applicable) # N/A
Changes
Improve the readability of the codebase by splitting the
LogProcessor
trait and its implementations into separate files. Does not introduce breaking changes or alter usage of these components in examples.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes