Skip to content

Split SimpleLogProcessor and BatchLogProcessor out of single file #2661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

drewrelmas
Copy link
Contributor

Fixes # N/A
Design discussion issue (if applicable) # N/A

Changes

Improve the readability of the codebase by splitting the LogProcessor trait and its implementations into separate files. Does not introduce breaking changes or alter usage of these components in examples.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@drewrelmas drewrelmas requested a review from a team as a code owner February 13, 2025 18:43
@drewrelmas drewrelmas marked this pull request as draft February 13, 2025 18:44
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 82.05446% with 145 lines in your changes missing coverage. Please review.

Project coverage is 79.1%. Comparing base (00ebc98) to head (4400ccf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/logs/batch_log_processor.rs 81.9% 100 Missing ⚠️
opentelemetry-sdk/src/logs/simple_log_processor.rs 82.2% 45 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2661   +/-   ##
=====================================
  Coverage   79.1%   79.1%           
=====================================
  Files        120     122    +2     
  Lines      22562   22562           
=====================================
  Hits       17861   17861           
  Misses      4701    4701           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drewrelmas drewrelmas marked this pull request as ready for review February 13, 2025 19:41
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There are other places that could benefit from similar rearrangement, feel free to explore and make changes when you have bandwidth!

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.

@lalitb lalitb merged commit cd9bbcf into open-telemetry:main Feb 14, 2025
21 checks passed
cijothomas pushed a commit to cijothomas/opentelemetry-rust that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants