-
Notifications
You must be signed in to change notification settings - Fork 516
fix: AtomicI64, AtomicU64 for xtensa arch #2773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2773 +/- ##
=====================================
Coverage 81.3% 81.3%
=====================================
Files 126 126
Lines 24251 24251
=====================================
+ Hits 19732 19736 +4
+ Misses 4519 4515 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@brunobrolesi Thanks! Can you check if this is only place where Atomics were used? It's okay to do it in a follow up, if you are okay with that. (Trying to make sure we do support extra architectures consistently across repo (wherever feasible)) |
Fixes #
I'm working on a personal project that tries to add observability to an mqtt system with ESP32 microcontrollers. When I tried to use the open telemetry crate to export my program's traces, I encountered the following build error:
Changes
After doing some analysis on the subject, I came across the following PR that had the same problem, but for other architectures. Based on the discussion of the PR, I made the changes for the architecture I am using and was able to use the stdout exporter, as can be seen in the image below:
One thing to note, this change only allowed me to use the stout exporter, the others had problems due to a compilation error related to the dependencies hyper and socket 2, this problem can be seen in the issues below:
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes