Skip to content

feat: Add timeout duration to shutdown #2789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mohammadVatandoost
Copy link
Contributor

@mohammadVatandoost mohammadVatandoost commented Mar 11, 2025

#2574 Part 1: Adding shutdown_with_timeout for Log and metric providers. Others will be added in another PR

@mohammadVatandoost mohammadVatandoost requested a review from a team as a code owner March 11, 2025 21:58
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 89.83051% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.7%. Comparing base (52cd0e9) to head (85b53d0).
Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
...y-sdk/src/logs/log_processor_with_async_runtime.rs 78.5% 3 Missing ⚠️
opentelemetry-sdk/src/logs/batch_log_processor.rs 87.5% 1 Missing ⚠️
opentelemetry-sdk/src/metrics/manual_reader.rs 0.0% 1 Missing ⚠️
opentelemetry-sdk/src/metrics/periodic_reader.rs 80.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2789   +/-   ##
=====================================
  Coverage   79.7%   79.7%           
=====================================
  Files        123     123           
  Lines      23136   23141    +5     
=====================================
+ Hits       18448   18452    +4     
- Misses      4688    4689    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing, I realized its better we make additive change everywhere to accept timeout.
#2574 (comment)

Also, please do one component at a time, to keep PR scope smaller - it is a lot easier to review small PRs.
I suggest starting with Exporter for Metrics. Then Reader+MeterProvider for Metrics. Then repeat for Logs, then traces and so on

@mohammadVatandoost
Copy link
Contributor Author

@cijothomas Ok I close this PR and I will create another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants