-
Notifications
You must be signed in to change notification settings - Fork 516
feat(otlp): Re-export tonic crate #2898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MathieuTricoire
wants to merge
12
commits into
open-telemetry:main
Choose a base branch
from
MathieuTricoire:re-export-tonic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+24
−11
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
aadc48f
feat(otlp): Re-export tonic crate
MathieuTricoire 31f38a7
add tonic to allowed external type list
MathieuTricoire 23fd53d
Merge branch 'main' into re-export-tonic
cijothomas a46b881
Merge branch 'main' into re-export-tonic
cijothomas e016808
Merge branch 'main' into re-export-tonic
cijothomas b491c2d
Merge branch 'main' into re-export-tonic
cijothomas 509e48c
Merge branch 'main' into re-export-tonic
lalitb 36fbc57
Merge branch 'main' into re-export-tonic
lalitb 710b2b2
Merge branch 'main' into re-export-tonic
MathieuTricoire bd0af70
re-export cherry-picked tonic types
MathieuTricoire 2150812
add documentation to re-exported tonic types
MathieuTricoire 19b5c90
clean allowed external types + update CI
MathieuTricoire File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -102,7 +102,7 @@ jobs: | |
run: | | ||
cargo install [email protected] | ||
cd ${{ matrix.example }} | ||
cargo check-external-types --config allowed-external-types.toml | ||
cargo check-external-types --all-features --config allowed-external-types.toml | ||
msrv: | ||
strategy: | ||
matrix: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that all of these should be reexported and removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bantonsson, thanks for the review!
The added types are the ones now re-exported.
I also updated the CI script to check allowed external types with all features enabled, because the previous configuration was correct but wasn't actually enforced (some re-exported types are feature-gated).
I've also cleaned up the old types that are no longer re-exported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation @MathieuTricoire. Didn't know how that plugin works.