-
Notifications
You must be signed in to change notification settings - Fork 916
Add predicate to MetricReader and MetricProducer #3566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
a4a1eb5
First version
asafm ccb52f2
remove whitespace
asafm 87a9197
remove added comma
asafm 9767e39
Remove instrument description from predicate parameters as even the v…
asafm 8a30be4
Marking predicate as experimental
asafm 552167e
Changing the proposal to be more specific by specifying the predicate…
asafm 98e1557
Update specification/metrics/sdk.md
asafm ccab0a9
Added experimental to FilterRules section
asafm 5b9d5ae
Revert "Added experimental to FilterRules section"
asafm 3e40a6c
Revert "Update specification/metrics/sdk.md"
asafm 8837585
Revert "Changing the proposal to be more specific by specifying the p…
asafm 5bcb595
Replaced the single function with an interface of two functions for p…
asafm 236bd7c
Small fixes
asafm fd84663
Merge remote-tracking branch 'upstream/main' into add-predicate
asafm 7d5cf0c
PR fixes
asafm d7a0138
Merge remote-tracking branch 'upstream/main' into add-predicate
asafm dedc53d
MetricFilter is now a parameter to MetricProducer's Produce operation
asafm b430e0c
Merge branch 'main' into add-predicate
asafm a82ffdd
Changed all naming in the interface of MetricFilter
asafm eb76eee
Remove params from headers
asafm ba242a0
Changed Reject to drop
asafm 1652efe
Removed too much details
asafm 7bb73b7
Updated TOC
asafm ad9efd3
Merge branch 'main' into add-predicate
asafm ee2880b
Fixed kind
asafm 3954c9a
Merge branch 'main' into add-predicate
asafm 70be5ca
lint fixes
asafm 04be7c3
Merge branch 'main' into add-predicate
asafm e587f7e
Add to CHANGELOG.md and spec-compliance-matrix.md
asafm d4166bd
fixed CHANGELOG.md
asafm 413763a
Merge branch 'main' into add-predicate
asafm 271398e
Merge branch 'main' into add-predicate
asafm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.