Skip to content

Balanced implementation for orml_tokens #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Chralt98 opened this issue Jul 3, 2023 · 1 comment · Fixed by #931
Closed

Balanced implementation for orml_tokens #930

Chralt98 opened this issue Jul 3, 2023 · 1 comment · Fixed by #931

Comments

@Chralt98
Copy link
Contributor

Chralt98 commented Jul 3, 2023

Hey,

is there any existing implementation for this trait https://paritytech.github.io/substrate/master/frame_support/traits/tokens/fungible/trait.Balanced.html ?

It seems like orml_tokens worked for polkadot version 0.9.40, but now I upgraded to 0.9.42.

the trait bound `orml_tokens::Pallet<Runtime>: hidden_include::traits::fungible::Balanced<sp_runtime::AccountId32>` is not satisfied

This is where it throws the error:

impl pallet_asset_tx_payment::OnChargeAssetTransaction<Runtime> for TokensTxCharger {
	type AssetId = BAsset;
	type Balance = Balance;
	type LiquidityInfo = Credit<AccountId, Tokens>;

For "Credit<AccountId, Tokens>" and Tokens is orml_tokens.

@xlc otherwise "We are running out of dots..." ;-)

@xlc
Copy link
Member

xlc commented Jul 3, 2023

Looks like it is indeed missing. PR are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants