Skip to content

Implement necessary Balanced types #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 6, 2023

Conversation

Chralt98
Copy link
Contributor

@Chralt98 Chralt98 commented Jul 4, 2023

Fixes #930

This implements the fungibles::Balanced traits associated types.

My reference is originally from here (an older default implementation for the Balanced trait inside of substrate).

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #931 (b4c0917) into master (28a2e6f) will increase coverage by 0.08%.
The diff coverage is 93.54%.

@@            Coverage Diff             @@
##           master     #931      +/-   ##
==========================================
+ Coverage   78.35%   78.44%   +0.08%     
==========================================
  Files         105      105              
  Lines       10709    10771      +62     
==========================================
+ Hits         8391     8449      +58     
- Misses       2318     2322       +4     
Impacted Files Coverage Δ
tokens/src/lib.rs 77.63% <71.42%> (-0.10%) ⬇️
tokens/src/tests_fungibles.rs 99.27% <100.00%> (+0.15%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Chralt98 Chralt98 requested a review from xlc July 5, 2023 06:45
@Chralt98 Chralt98 requested a review from xlc July 6, 2023 09:38
@xlc xlc merged commit 7ecebea into open-web3-stack:master Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Balanced implementation for orml_tokens
2 participants