-
Notifications
You must be signed in to change notification settings - Fork 300
Implement necessary Balanced types #931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #931 +/- ##
==========================================
+ Coverage 78.35% 78.44% +0.08%
==========================================
Files 105 105
Lines 10709 10771 +62
==========================================
+ Hits 8391 8449 +58
- Misses 2318 2322 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xlc
reviewed
Jul 4, 2023
xlc
reviewed
Jul 6, 2023
xlc
reviewed
Jul 6, 2023
Chralt98
commented
Jul 6, 2023
xlc
approved these changes
Jul 6, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #930
This implements the
fungibles::Balanced
traits associated types.My reference is originally from here (an older default implementation for the Balanced trait inside of substrate).