Skip to content

Integrate Rococo V1 #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Mar 11, 2021
Merged

Integrate Rococo V1 #332

merged 25 commits into from
Mar 11, 2021

Conversation

shaunxw
Copy link
Member

@shaunxw shaunxw commented Dec 2, 2020

No description provided.

This was referenced Dec 2, 2020
@shaunxw shaunxw changed the title Integrate Rococo V1 WIP - Integrate Rococo V1 Jan 20, 2021
@shaunxw
Copy link
Member Author

shaunxw commented Jan 20, 2021

WIP, made ready for review to trigger CI.

@shaunxw shaunxw marked this pull request as ready for review January 20, 2021 00:24
@shaunxw shaunxw changed the title WIP - Integrate Rococo V1 Integrate Rococo V1 Mar 10, 2021
@olanod
Copy link
Contributor

olanod commented Mar 10, 2021

Looking nice :) Wondering if there are mayor blockers like protocol changes that stop this from being merged? would you say is safe enough to to try out xtokens in its current state even if its just locally?

@xlc
Copy link
Member

xlc commented Mar 10, 2021

You can definitely give it a try. One reason we have not merged this yet is this branch is targeting to rococo-v1, which is a fast moving target and have breaking changes from time to time.

@shaunxw shaunxw requested a review from xlc March 11, 2021 02:15
@shaunxw shaunxw mentioned this pull request Mar 11, 2021
@shaunxw shaunxw merged commit 1479ea3 into master Mar 11, 2021
@shaunxw shaunxw deleted the sw/rococo-v1 branch March 11, 2021 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants