Skip to content

add whitelist_account #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2021
Merged

add whitelist_account #464

merged 2 commits into from
Apr 29, 2021

Conversation

xlc
Copy link
Member

@xlc xlc commented Apr 27, 2021

No description provided.

@xlc xlc enabled auto-merge (squash) April 27, 2021 05:46
@xlc xlc merged commit f6ecabf into master Apr 29, 2021
@xlc xlc deleted the whitelist-account branch April 29, 2021 23:30
@shawntabrizi
Copy link

is there a reason you have forked benchmarking completely? We are changing it too much?

@xlc
Copy link
Member Author

xlc commented Apr 30, 2021

Mainly most of Acala pallets have tight coupling and it is impossible to write generic benchmark tests. We need to access the Runtime struct. As result, many of our benchmarks are ends up in the runtime https://github.com/AcalaNetwork/Acala/blob/master/runtime/mandala/src/benchmarking/cdp_engine.rs

One specific example is that our Balance type is not generic https://github.com/AcalaNetwork/Acala/blob/b813733865b875176c7c9336c5515397c65ab90d/modules/cdp-engine/src/lib.rs#L158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants